Re: [libvirt] [PATCH 08/11] conf: Prefer pcie-to-pci-bridge to dmi-to-pci-bridge

> needDMIToPCIBridge = true; > + needPCIeToPCIBridge = true; > for (i = 0; i < addrs->nbuses; i++) { > if (addrs->buses[i].flags & VIR_PCI_CONNECT_TYPE_PCI_BRIDGE) { > needDMIToPCIBridge = false; > + needPCIeToPCIBridge = false; > break; > } > } > - if (needDMIToPCIBridge && add == 1) { > + > + /* Prefer pcie-to-pci-bridge, fall back to dmi-to-pci-bridge */ > + if (addrs->isPCIeToPCIBridgeSupported) > + needDMIToPCIBridge = false; > + else > + needPCIeToPCIBridge = false; The above seems a bit extra work and is a bit hard to read... Could the previous for loop change to use a new bool "needXToPCIBridge"... Then, I think it would just be: if (addrs->isPCIeToPCIBridgeSupported) needPCIeToPCIBridge = needXToPCIBridge; else needDMIToPCIBridge = needXToPCIBridge; with the following just being if (needXToPCIBridge && add == 1) What you have works, just seems to be overkill or maybe I'm missing something subtle ;-).