Re: [libvirt] [PATCH 37/41] remote: handle autoprobing of driver within virtproxyd

On Tue, 2019-07-23 at 17:03 +0100, Daniel P. Berrangé wrote: [...] > +++ b/src/remote/remote_daemon_dispatch.c > +static int > +remoteDispatchProbeURI(bool readonly, char **probeduri) Once again, there should be one argument per line and a personal preference I'd rather have readonly as the last one, but you can safely ignore the latter comment if you feel otherwise.

[...] > + /* Even if we didn't probe any socket, we won't > + * return error. Just let virConnectOpen's normal > + * logic run which will likely return an error anyway > + */ I didn't verify this myself, but I hope that when you wrote "likely" above what you really meant was "definitely", "certainly", "absolutely", "without any doubt" or something along those lines ;)