On Tue, Mar 28, 2023 at 01:58:03PM +0200, Michal Privoznik wrote:
This is fairly trivial. Just set .memaddr attribute if a value
was set in the XML.
Resolves:
https://bugzilla.redhat.com/show_bug.cgi?id=2180679
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
src/qemu/qemu_command.c | 1 +
.../memory-hotplug-virtio-mem.x86_64-latest.args | 2 +-
.../memory-hotplug-virtio-pmem.x86_64-5.2.0.args | 2 +-
.../memory-hotplug-virtio-pmem.x86_64-latest.args | 2 +-
4 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 7e75354902..717dadd492 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -3628,6 +3628,7 @@ qemuBuildMemoryDeviceProps(virQEMUDriverConfig *cfg,
"T:unarmed", unarmed,
"s:memdev", memdev,
"B:prealloc", prealloc,
+ "P:memaddr", mem->address,
Only here I figured out to think whether it might be possible to have
the dimm mapped to address 0, but it's fine.
Reviewed-by: Martin Kletzander <mkletzan(a)redhat.com>
and SFF (and the second one too, I forgot to mention it there, but I
think that's a given)