Re: [PATCH v1] meson: recognize sles when guessing default_qemu_user
On Tue, Jan 25, 2022 at 06:30:43PM +0100, Olaf Hering wrote:
Tue, 25 Jan 2022 09:16:33 -0800 Andrea Bolognani
<abologna(a)redhat.com>:
> /etc/os-release being absent should not result in a build failure.
Yes. This should be the first thing to fix.
Commit 29cd1877acd91883df32bf71ec07fe908e96db32 does not say why ID=
was used. This grep should be relaxed to ID_LIKE=.
We have to consider *both*, because only looking at ID_LIKE would not
work on some distros:
$ grep -E '^ID(_LIKE)*=' /etc/os-release
ID=fedora
$
Furthermore, if both qemu_user and qemu_group are known, no grep is
required.
Do you mean that if the user has passed
-Dqemu_user=... -Dqemu_group=...
to meson we could skip the detection logic? That'd be nice, but I'm
afraid it might make the code less readable for very little gain.
Are you going to take a stab at these patches?
--
Andrea Bolognani / Red Hat / Virtualization