Re: [libvirt] [PATCH 0/5] Couple of wireshark fixes
On Mon, Jan 04, 2016 at 12:26:22PM +0100, Michal Privoznik wrote:
Well, I've just updated wireshark on my system and encountered
couple of
compile errors while building libvirt. Here are the fixes. Fortunately, none of
them requires us to increase the version number of wireshark that's required.
However, I'd like to discuss how are we going to handle this. I mean, at
wireshark they don't seem so committed to API stability as we are. Therefore
this patch set. In the long term I don't see us adapting to every single API
change, or do I? Although I am not sure what are our options here.
I thought about this long and hard. And we discussed it together
off-list as well. And the only conclusion I could come up with is that
if wireshark people don't want our dissector in, with us updating it
every once in a while, then I would just say that we support few last
versions (intentionally arbitrary number, so that we can drop support
for older stuff whenever we please). And for those few versions we
would just #ifdef the heck out of it. It's just that I don't feel like
keeping all the old versions around in separate files or anything like
it. I'm more than open to other ideas, though.
Anyway, ACK for this series at least.
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)