Re: [libvirt] [RFC] test_driver: Thoughts on the implementation of some FS-related APIs

On Thu, Jul 4, 2019 at 12:58 PM Pavel Hrdina <phrdina(a)redhat.com&gt; wrote: > > On Wed, Jun 26, 2019 at 06:36:28PM +0200, Ilias Stamatis wrote: > > Hello, > > > > I was thinking about how to implement the following APIs in the test driver: > > -virDomainFSFreeze > > -virDomainFSThaw > > -virDomainFSTrim > > > > The first two are conceptually paired. They both get a mountpoints > > argument. The QEMU driver (which is the only driver implementing this > > currently) ignores this completely. > > What do you mean by "ignores this completely"? From the code the > mountpoints are passed to QEMU agent and that agent issues appropriate > commands in the VM OS. I meant qemuDomainFSThaw and qemuDomainFSTrime. In the case of virDomainFSFreeze you are right.