Re: [libvirt] [PATCH 5/6] conf: start testing contents of the new backing chain fields

On 04/09/14 06:35, Eric Blake wrote: > The testsuite is absolutely essential to feeling comfortable > about swapping the backing chain structure over to a new format. > This patch tests the path settings, and demonstrates that the > correct short name is being passed to the child. > > * tests/virstoragetest.c (testStorageChain): Test path. > (mymain): Update expected data. > > Signed-off-by: Eric Blake <eblake(a)redhat.com&gt; > --- > tests/virstoragetest.c | 69 ++++++++++++++++++++++++++++++++++++++++---------- > 1 file changed, 56 insertions(+), 13 deletions(-) > > diff --git a/tests/virstoragetest.c b/tests/virstoragetest.c > index 093053a..9c2f815 100644 > --- a/tests/virstoragetest.c > +++ b/tests/virstoragetest.c > @@ -294,22 +297,28 @@ testStorageChain(const void *args) > > expBackingDirectory = abs ? data->files[i]->expBackingDirAbs > : data->files[i]->expBackingDirRel; > + expPath = abs ? data->files[i]->pathAbs > + : data->files[i]->pathRel; This will need to be updated as in 2/6 due of the upstream changes.

ACK with build failure resolved.