Re: [libvirt] [PATCH v4 2/2] libxl: implement NUMA capabilities reporting
On lun, 2013-08-12 at 14:25 -0600, Jim Fehlig wrote:
> diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c
> index 827dfdd..2c84191 100644
> --- a/src/libxl/libxl_conf.c
> +++ b/src/libxl/libxl_conf.c
> @@ -161,6 +161,107 @@ libxlBuildCapabilities(virArch hostarch,
> }
>
> static virCapsPtr
> +libxlMakeNumaCapabilities(libxl_numainfo *numa_info,
> + int nr_nodes,
> + libxl_cputopology *cpu_topo,
> + int nr_cpus,
> + virCapsPtr caps)
>
I know we discussed returning an int from this function to indicate
success/failure, and that I agreed with your reasoning [1] to keep the
virCapsPtr. But now that driver init fails if gathering NUMA fails, I
think this really should return an int.
To be fully honest, I knew you were going to say that! :-P It's just,
with the code looking like it does _before_ your patch reworking the
host and guest capabilities, I still liked my approach more, and that's
why I decided to give it a try!
With your patch (the one in [2]) in place, I probably also think that
making this a "proper function" returning an int.
I sent a patch to rework the capabilities code [2], which I think
will
make it a bit easier to implement this function. What do you think?
I think I like it, and I can certainly rework this patch one more time
on top of yours. Apparently, this patch seems to suffer from some
particular bad luck, since I'm going on vacation for ~2 weeks, so such
rework and repost will be delayed some more time. :-P
Anyway, thanks for having a look at it. I'll respin the patch as soon as
coming back to work.
[1]
https://www.redhat.com/archives/libvir-list/2013-July/msg00458.html
[2] https://www.redhat.com/archives/libvir-list/2013-August/msg00543.html
Regards,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
Attachments:
- signature.asc (application/pgp-signature — 198 bytes)