On a Wednesday in 2025, Kirill Shchetiniuk via Devel wrote:
This series refactors the existing parse logic by using the proper
utility
functions, it also contains some parameters type changes to void
unnecessary type convertions.
1. 'VNC' graphics pasing were refactored to use the vitXMLProp* utility
functions.
'autoport' and 'websocketGenerated' remain their bool type, as this
structure
members can be also modified later and not only determined by the initial XML
definition.
2. 'RDP' graphics refactored same as VNC graphics, except that 'multiUser'
and
'replaceUser' types changed from bool to tristateBool, as parameters are
determined only by the initial XML.
3. 'SDL' graphics fullscreen option type changed from bool to tristateBool,
to avoid unnecessary type convertions.
4. 'desktop' graphics fullscreen option is removed as it was never used.
Kirill Shchetiniuk (4):
conf: VNC graphics parse refactor
conf: SDL fullscreen option refactor
conf: RDP graphics parse refactor
conf: desktop graphics remove unused option
docs/formatdomain.rst | 5 +-
src/conf/domain_conf.c | 125 ++++++++++++++----------------
src/conf/domain_conf.h | 7 +-
src/conf/schemas/domaincommon.rng | 5 --
src/qemu/qemu_command.c | 2 +-
src/qemu/qemu_process.c | 4 +-
src/qemu/qemu_validate.c | 4 +-
src/vbox/vbox_common.c | 8 +-
8 files changed, 71 insertions(+), 89 deletions(-)
Reviewed-by: Ján Tomko <jtomko(a)redhat.com>
I will push the series after my pipeline succeeds
Jano