Re: [libvirt] [PATCH v5 01/36] qemu_process: Move process code from qemu_capabilities to qemu_process
On Sun, Dec 02, 2018 at 23:09:55 -0600, Chris Venteicher wrote:
Qemu process code in qemu_capabilities.c is moved to qemu_process.c
in
order to make the code usable outside the original capabilities
usecases.
The moved code activates and manages Qemu processes without
establishing a guest domain.
** This patch is a straight cut/paste move between files. **
I don't think there's any need for the stars here.
(Exception: I did change a function prototype in qemu_process.h to be
one
parameter per line.)
There's really no exception. There were no prototypes at all in the
original code since the functions were used in the same file where they
were defined. While moving the code, you naturally had to add
prototypes. Please drop this part of the commit message.
Then, subsequent patches modify the process code
to make function prefixes and variable names match qemu_process,
and make the code usable for more than the capabilities usecase.
Signed-off-by: Chris Venteicher <cventeic(a)redhat.com>
Reviewed-by: Jiri Denemark <jdenemar(a)redhat.com>