Re: [libvirt] [PATCH] umlAutostartDomain: avoid NULL-deref upon virGetLastError failure
Eric Blake wrote:
On 05/17/2010 09:09 AM, Jim Meyering wrote:
>> That looks awkward to end with a trailing space. Might it be better to use:
>>
>> err ? err->message : _("unknown reason")
>>
>> At any rate, ACK that this fixes a potential NULL deref.
>
> That's a good point.
However, considering there are 20 others just like it,
and in the spirit of keeping this fix minimal, I've pushed it as-is.
> I considered going one step further and changing
> virGetLastError so that it never returns NULL,
> instead returning a pointer to a static buffer where
> err->message is something like "internal failure".
...