Re: [libvirt] [PATCHv2 1/1] Remove contiguous CPU indexes assumption

On Fri, Mar 15, 2013 at 05:25:09PM +0800, Li Zhang wrote: > From: Li Zhang<zhlcindy(a)linux.vnet.ibm.com> > > When getting CPUs' information, it assumes that CPU indexes > are not contiguous. But for ppc64 platform, CPU indexes are not > contiguous because SMT is needed to be disabled, so CPU information > is not right on ppc64 and vpuinfo, vcpupin can't work corretly. > > This patch is to remove the assumption to be compatible with ppc64. > > Test: > 4 vcpus are assigned to one VM and execute vcpuinfo command. > > Without patch: There is only one vcpu informaion can be listed. > With patch: All vcpus' information can be listed correctly. > > Signed-off-by: Li Zhang<zhlcindy(a)linux.vnet.ibm.com> > --- > v2 -> v1: > * Remove unused cpu variable suggested by Daniel P.Berrange > * Remove contigous assumption in qemu_monitor_text.c suggested by Daniel P.Berrange > > src/qemu/qemu_monitor_json.c | 14 -------------- > src/qemu/qemu_monitor_text.c | 13 ++----------- > 2 files changed, 2 insertions(+), 25 deletions(-) ACK Daniel