Re: [libvirt] [PATCH v2 1/9] virsh: Introduce virshStoragePoolNameCompleter

Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com&gt; --- Diff to v1: - Pruned the list of flags accepted in the callback - Pools for vol_* are ACTIVE only - Other small nits raised in the review tools/virsh-completer.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++++ tools/virsh-completer.h | 4 ++++ tools/virsh-pool.c | 28 ++++++++++++++-------------- tools/virsh-volume.c | 10 +++++++--- tools/virsh.h | 6 ++++-- 5 files changed, 77 insertions(+), 19 deletions(-)