Re: [libvirt] [PATCH 3/3] tests: deterministichash: Make hash tables arch-independent
Peter Krempa <pkrempa(a)redhat.com> [2017-08-02, 05:39PM +0200]:
It turns out that our implementation of the hashing function is
endian-dependent and thus if used on various architectures the testsuite
may have different results. Work this around by mocking virHashCodeGen
to something which does not use bit operations instead of just setting a
deterministic seed.
This does fix the issue on S390. Anyways, I'd also like to see the tests
fixed that rely on the ordering of the hash table. And code that uses
the hash table should be tested that it does NOT rely on the ordering.
Tested-by: Bjoern Walk <bwalk(a)linux.vnet.ibm.com>
Attachments:
- signature.asc (application/pgp-signature — 896 bytes)