Masayuki Sunou wrote:
Hi
Because virsh vcpupin does not check a form of <cpumap>,
when non-numerical letters are set, it does not become an error.
This patch fixes it so that it become an error when non-numerical
letters are set.
You mean cpulist instead of cpumap? Your patch doesn't deal with
strings like "1,,,,3".
<rant> It's 2007 - we should not be writing any more software in C.
</rant>
There seem to be another problem with the documentation of virsh vcpupin
too. It's documented as 'virsh vcpupin <domain>' yet takes two other
parameters, so should really be 'virsh vcpupin <domain> <vcpu>
<cpulist>'.
The attached patch (not applied) should fix all of the above.
Rich.
--
Emerging Technologies, Red Hat -
http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in
England and Wales under Company Registration No. 03798903