Re: [PATCH 2/2] qemu: Validate TPM TIS device
On Wed, 2021-02-10 at 10:34 -0700, Jim Fehlig wrote:
I aslo worry about future architectures gaining support
for emulated TPM TIS devices.
It's okay to be conservative - we can always relax the check later.
+ if (!ARCH_IS_X86(def->os.arch) &&
(def->os.arch != VIR_ARCH_AARCH64)) {
+ virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
+ _("TPM model %s is only available for "
+ "x86 and aarch64 guests"),
Please don't split the error message into two separate lines, and
sprinkle some quotes around '%s' while you're at it.
https://libvirt.org/coding-style.html#error-message-format
--
Andrea Bolognani / Red Hat / Virtualization