Re: [libvirt] [PATCH 1/2] qemu: Add missing lock of virDomainObj before calling virDomainUnref

> I think the real reason for the deadlock is that: > > qemudDomainSaveFlag holds the domain lock while it calls > qemuDomainEventQueue, which requests the event loop lock > > the event loop thread holds the event loop lock, and can make several > different callbacks that can result in requesting a domain lock I don't think this can be the deadlock scenario. The event loop lock is completely isolated from other locks, because it is only ever held while code in event.c is executing. It is always released when invoking any external callbacks, so you can't have any lock ordering dependencies wrt the event loop lock.