Re: [libvirt] [PATCH 2/3] Support for vrdp/sdl/gui while dumping xml

> - def->graphics->data.rdp.autoport = 1; > + valueDisplayUtf8 = getenv("DISPLAY"); > + valueDisplayFree = 0; > } Using getenv() here is not right, since that's running in the context of the app using libvirt. If there's no display available via virtualbox's API, then just leave this attribute blank when generating the XML. There's generally quite a few uses of strdup() here without OOM checking