Re: [libvirt] [PATCH 4/4] PowerPC : Do not allow floppy disks in domain XML.

Subject: [PATCH 4/4] PowerPC : Do not allow floppy disks in domain XML. PowerKVM does not support floppy disks. Ensure that libvirt honours this. Fixes : https://bugzilla.redhat.com/show_bug.cgi?id=1180486 Signed-off-by: Prerna Saxena <prerna(a)linux.vnet.ibm.com&gt; --- src/conf/domain_conf.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 6a57d80..df3a768 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -13892,6 +13892,14 @@ virDomainDefParseXML(xmlDocPtr xml, if (!disk) goto error; + if (ARCH_IS_PPC64(def->os.arch) && + STREQLEN(def->os.machine, "pseries", 7) &&

+ disk->device == VIR_DOMAIN_DISK_DEVICE_FLOPPY) { + virReportError(VIR_ERR_INTERNAL_ERROR,

+ _("Pseries machine does not support floppy device"));