Re: [libvirt] [PATCHv2] virsh: blkdeviotune: accept human readable values for bytes
On 04.05.2016 16:25, Nishith Shah wrote:
[1] .. here.
Use vshCommandOptScaledInt instead of vshCommandOptULongLong so that
values with suffixes can be passed when bytes are being passed along.
Values for the iops parameters still need to be given in the absolute
form as they are not bytes but numbers. Please refer to the bug link
https://bugzilla.redhat.com/show_bug.cgi?id=885380 which can be closed.
I've moved this bug reference [1]. It's our common way of referring bugs
in commit messages.
Signed-off-by: Nishith Shah <nishithshah.2211(a)gmail.com>
---
tools/virsh-domain.c | 24 ++++++++++++------------
tools/virsh.pod | 18 ++++++++++++------
2 files changed, 24 insertions(+), 18 deletions(-)
ACKed and pushed.
Congratulations on your first libvirt contribution!
Michal