On Thu, Feb 16, 2023 at 16:51:46 -0600, Jonathon Jongsma wrote:
On 2/16/23 10:43 AM, Peter Krempa wrote:
On Tue, Feb 14, 2023 at 11:08:14 -0600, Jonathon Jongsma wrote:
Right now, ssh network disks are not usable. There is some basic support in libvirt that is meant to support disk chains that have backing disks located at ssh urls, but there is no real way for a user to configure a ssh-based disk. This commit allows users to configure an ssh disk with password authentication. Implementation will follow.
<disk type='network'> <source protocol='ssh' ...> <auth username='myusername'> <secret type='iscsi' usage='secretname'/> </auth> </disk>
Signed-off-by: Jonathon Jongsma <jjongsma@redhat.com> --- docs/formatdomain.rst | 27 ++++++++++++++------------- src/conf/schemas/domaincommon.rng | 23 ++++++++++++++++++++++- 2 files changed, 36 insertions(+), 14 deletions(-)
[...]
+ the password). Known secret types are "ceph" for Ceph RBD network sources + and "iscsi" for CHAP authentication of iSCSI targets. Both will require + either a ``uuid`` attribute with the UUID of the secret object or a + ``usage`` attribute matching the key that was specified in the secret + object.
This paragraph doesn't really state what to put into 'type' for ssh as 'ceph' and 'iscsi' are only mentioned. For 'ssh' we need a 'ssh' type.
Hmm, do we also need a separate type for http auth as well, then? At the moment we seem to just re-use the 'iscsi' type for all of the http auth in our tests (e.g. disk-cdrom-network.xml, etc).
Good point! Let's deal with that later. Reviewed-by: Peter Krempa <pkrempa@redhat.com>