On 03/30/2010 02:52 PM, Matthias Bolte wrote:
2010/3/30 Jiri Denemark <jdenemar(a)redhat.com>:
> Hi.
>
> ...
>> /* NOTE: struct _virDomainSnapshot is a private structure, ala
>> * struct _virDomain.
>> */
>> typedef struct _virDomainSnapshot virDomainSnapshot;
>>
>> /* Take a snapshot of the current VM state. Throws an error if
>> * the VM is not currently running */
>> virDomainSnapshotPtr virDomainSnapshotCreateXML(virDomainPtr domain,
>> const char *xmlDesc,
>> unsigned int flags);
>
> This is probably a leftover from previous versions, but... why do we restrict
> this API only for running VMs?
>
Yep, if a domain it not running you'll just get a disk snapshot
without a memory snapshot.
Is taking a halted disk snapshot something we might want to allow with a
flag, though? For that matter, is this API useful for taking a disk
snapshot and disregarding a memory snapshot even of a running VM?
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library
http://libvirt.org