Re: [libvirt] [PATCHv2 0/4] Add LibSSH2 transport
On Sat, Aug 11, 2012 at 4:20 PM, Peter Krempa <pkrempa(a)redhat.com> wrote:
This is a second respin of the LibSSH2 transport patch series.
Annoyingly Gmail has decided to eat patch 1/4 so I've been reviewing
it on the ML archives. I've noticed the following:
virNetLibSSH2CheckHostKey() the virBuffer buff is leaked in a few
places. After the following line:
keyhash = virBufferContentAndReset(&buff);
buff isn't freed in all the cases that you can return.
Overall the patch looks great. I haven't applied it locally and tested it yet.
--
Doug Goldstein