Re: [libvirt] [PATCH] libvirtd: Better initscript error reporting

According to Cole Robinson on 2/24/2010 10:55 AM: Why the switch from -x to -e? If libvirtd is missing executable permissions, it can now get through this check whereas before it exited early. Group the failure, in case echo also fails (such as for a full disk); also, I'm used to not seeing trailing . on error messages, but it is polite to attribute who's printing the failure. Printing to stderr is also nice. Something like: [...] && { echo "$0: $LIBVIRTD_BIN not found" 2>&1; exit 1; } -- Eric Blake eblake(a)redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org