Re: [libvirt] [jenkins-ci PATCH 4/8] guests: libosinfo needs libcurl and wget
On Wed, 2018-05-16 at 10:44 +0200, Pavel Hrdina wrote:
On Tue, May 15, 2018 at 04:40:05PM +0200, Andrea Bolognani wrote:
> libcurl is used directly, and wget is used to retrieve PCI
> and USB IDs at build time on platforms that don't ship them
> as part of the operating system, such as MinGW.
>
> Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
> ---
> guests/vars/projects/libosinfo+mingw.yml | 3 +++
> guests/vars/projects/libosinfo.yml | 1 +
> 2 files changed, 4 insertions(+)
Reviewed-by: Pavel Hrdina <phrdina(a)redhat.com>
Note: minimal installation of CentOS doesn't ship wget by default so I
guess we might need to extend the list of dependencies. Currently it
works on CentOS 7 because we are building libvirt-cim which has wget as
explicit dependency.
wget is only needed for MinGW builds, the native one uses the
contents of the pci-ids and usb-ids packages, which are
explicitly installed on CentOS as well as other native platforms.
So this is the only change that's needed.
--
Andrea Bolognani / Red Hat / Virtualization