Re: [libvirt] [PATCH v3 2/2] bhyve: add xml2args unittest
Ján Tomko wrote:
> +static virCapsPtr
> +testBhyveBuildCapabilities(void)
> +{
> + virCapsPtr caps;
> + virCapsGuestPtr guest;
> +
> + if ((caps = virCapabilitiesNew(virArchFromHost(),
Getting the arch from the host seems wrong in a test, but it seems the bhyve
driver doesn't care about archs.
That's correct, bhyve driver doesn't care about archs currently.
> + if (!(conn = virGetConnect()))
Does this have any side-effects? It doesn't seem to be used anywhere.
No, it doesn't, I dropped it.
caps and xmlopt should be unref'd here.
Fixed.
ACK with the leak fixed and virGetConnect removed (or explained).
Thanks! Pushed with these fixes.
Roman Bogorodskiy