Re: [PATCH 02/16] conf: Add parser logic for nwfilter metadata fields

On 9/3/23 17:49, K Shiva Kiran wrote:

Signed-off-by: K Shiva Kiran <shiva_kr@riseup.net> --- src/conf/nwfilter_conf.c | 30 ++++++++++++++++++++++++++++++ src/conf/nwfilter_conf.h | 5 +++++ 2 files changed, 35 insertions(+)

Here, I'd also expect a test case. Either introduce a new test case to tests/nwfilterxml2xmltest.c (preferred), or modify an existing one. This not only verifies the parsing/formatting works, but also that our schema is valid. Michal