Re: [libvirt] [PATCH RFC] virsh: Fix semantics of --config for "update-device" command
On 03/15/2013 12:37 PM, Peter Krempa wrote:
The man page states that with --config the next boot is affected.
This
can be understood as if _only_ the next bood was affected. This isn't
true if the machine is running.
This patch adds the full --live, --config, --current infrastructure and
tweaks stuff to correctly support the obsolete --persistent flag.
---
Notes:
- This patch will be greatly simplified with macros from:
http://www.redhat.com/archives/libvir-list/2013-March/msg00268.html
- There are multiple places like this in virsh that will need update too.
(detach-device for example)
I agree that the way the options work in the various commands is
inconsistent and it would be nice if that wasn't the case, but fixing it
is a road fraught with perils. Keep in mind that there are likely
already scripts written and deployed using the current meaning of the flags.