Re: [libvirt] [PATCH 07/12] storage: use GRegex virStorageBackendLogicalParseVolExtents

On Wed, Nov 13, 2019 at 16:48:48 +0100, Ján Tomko wrote:

Using GRegex simplifies the code since g_match_info_fetch will copy the matched substring for us.

Signed-off-by: Ján Tomko <jtomko@redhat.com> --- src/storage/storage_backend_logical.c | 49 +++++++-------------------- 1 file changed, 13 insertions(+), 36 deletions(-)

I'm getting a build failure with this patch: ../../src/storage/storage_backend_logical.c:128:11: error: variable 'p' set but not used [-Werror=unused-but-set-variable] 128 | char *p = NULL;