On 11/12/20 3:46 PM, Peter Krempa wrote:
Saying that virDomainQemuAgentCommand is fully supported to be used
would free us from having to add arbitrary unextendable APIs for every
single guest agent API, but would still allow libvirt to use APIs we
need.
By saying that mgmt apps will need to learn json apart from xml. I'm not
saying it's necessarily a bad thing - mgmt application is probably
written in a language that already has a JSON library built in (golang,
python).
We just need to make 100% sure that it can't be abused as argument to
to change status of virDomainQemuMonitorCommand.
There is a difference. You can configure qemu-ga for your guest so that
libvirt doesn't know about it (and does not use it), but your app can
still talk to it (just don't assign the org.qemu.guest_agent.0 name).
With monitor it's not possible; we could not guarantee anything if we'd
give up monitor.
Michal