Re: [libvirt] [PATCH v6 5/6] virsh: Expose new virDomainFSFreeze and virDomainFSThaw API

On 05/01/2014 03:38 AM, Daniel P. Berrange wrote: The repeated option is not required to be last in the user's command line, only that it is declared last in the C code. However, using a repeated option in anything other than the last position makes for more work for the end user. As an example, these two commands are equivalent: $ virsh echo --shell hello\! world 'hello!' world $ virsh echo --string hello\! --string world --shell 'hello!' world Supporting more than one option to be repeated might be possible (you'd have to patch the option parser to allow it), but using that gets tricky (you now HAVE to supply the option name for practically all repetitions of the option; at most one of the repeated options can take advantage of positional encoding for omitting the option name). But this particular example doesn't strike me as a case where we need multiple repeated options - multiple mountpoints is really all the more this command needs, and that works just fine with the existing framework, without needing to invent support for a command with two repeated options. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org