Re: [libvirt] [PATCH v2 08/17] qemu: assume -drive argument is always available
On Mon, Nov 09, 2015 at 06:24:07PM -0500, John Ferlan wrote:
On 11/09/2015 11:24 AM, Daniel P. Berrange wrote:
> As of QEMU 0.9.1 the -drive argument can be used to configure
> all disks, so the QEMU driver can assume it is always available
> and drop support for -hda/-cdrom/etc.
>
As I found out (and provided some details in patch 17) - the
qemuParseCommandLine should probably fail when -hd, -sd, -fd, -cdrom are
found... Since we won't be able to parse or create xml for them. It'll
make sense later, but think about parsing "-sdl" and what happens..
Actually, the -hd, -cdrom, etc args still exist in QEMU today. The
intention with the command line parsing is that we be able to parse
anything that the user might throw at us. So we should leave all
the parsing code in place, even if we don't ever generate the
corresponding args.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|