Re: [libvirt] [PATCHv6 2/3] libvirt/qemu - support persistent modification of qemu disks

Sometimes, qemuDomainAssignPCIAddress() failed, and it does not report error. qemuDomainAssignPCIAddress() calls qemuDomainPCIAddressSetCreate() that calls virDomainDeviceInfoIterate() that calls qemuCollectPCIAddress() that calls virHashAddEntry() that calls virHashAddOrUpdateEntry() When the pci address of two drivers are the same, virHashAddOrUpdateEntry() will fail. if (found) { if (is_update) { if (table->dataFree) table->dataFree(insert->payload, insert->name); insert->payload = userdata; return (0); } else { return (-1); <==== we do not report error here. } }