Re: [libvirt PATCH] docs: virConnectGetCapabilities do not provide pool types
Upon further reflection and some memory jiggling...
virsh -c storage:///system capabilities
<capabilities>
<pool>
<enum name='type'>
<value>dir</value>
<value>fs</value>
<value>netfs</value>
<value>logical</value>
<value>iscsi</value>
<value>iscsi-direct</value>
<value>scsi</value>
<value>mpath</value>
<value>disk</value>
<value>rbd</value>
<value>sheepdog</value>
<value>gluster</value>
<value>zfs</value>
</enum>
</pool>
</capabilities>
But yeah, without the -c storage:///system one won't see the results
because 'npools == 0' when virCapabilitiesFormatStoragePoolXML is called
from virCapabilitiesFormatXML unless it's the storage driver URI.
John
On 7/20/20 1:31 PM, John Ferlan wrote:
On 7/20/20 3:50 AM, Pino Toscano wrote:
> Remove the paragraph in the storage pool page that mentions
> virConnectGetCapabilities, as virConnectGetCapabilities does not return
> any information about pools.
>
> Signed-off-by: Pino Toscano <ptoscano(a)redhat.com>
> ---
> docs/formatstoragecaps.html.in | 6 ------
> 1 file changed, 6 deletions(-)
>
I was asked by Pino to review to be "ok" with removal, so yeah:
Reviewed-by: John Ferlan <jferlan(a)redhat.com>
John
If anyone cares to dredge up history back in Jan/Feb 2019 I believe it
was a true statement in at least a patches I had locally, but reviews,
conversations, and other adjustments to the code changed that. Been too
long to recall all those details.
> diff --git a/docs/formatstoragecaps.html.in b/docs/formatstoragecaps.html.in
> index ee3888f44d..d8a1cacd96 100644
> --- a/docs/formatstoragecaps.html.in
> +++ b/docs/formatstoragecaps.html.in
> @@ -13,12 +13,6 @@
> supported, and if relevant the source format types, the required
> source elements, and the target volume format types. </p>
>
> - <p>The Storage Pool Capabilities XML provides more information than the
> - <a
href="/html/libvirt-libvirt-host.html#virConnectGetCapabilities">
> - <code>virConnectGetCapabilities</code>
> - </a>
> - which only provides an enumerated list of supported pool types.</p>
> -
> <h2><a id="elements">Element and attribute
overview</a></h2>
>
> <p>A query interface was added to the virConnect API's to retrieve
the
>