Re: [libvirt] [PATCH v2 2/2] virSysinfoReadARM: Try reading DMI table
On Fri, 2019-05-10 at 14:20 +0200, Michal Privoznik wrote:
[...]
+static bool
+virSysinfoDefEmpty(const virSysinfoDef *def)
This is a predicate, so please call it virSysinfoDefIsEmpty().
+{
+ return !(def->bios || def->system || def->nbaseBoard ||
+ def->chassis || def->nprocessor || def->nmemory ||
def->oemStrings);
For nbaseBoard, nprocessor and nmemory you should use explicit
numeric comparison, according to the recently updated contributor
guidelines[1].
With the two nits above addressed,
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
[1] https://libvirt.org/hacking.html#conditions
--
Andrea Bolognani / Red Hat / Virtualization