Re: [libvirt] [PATCH 4/4] qemu: snapshot: Fix return value of external checkpoint with no disks
On 05/20/2014 10:16 AM, Eric Blake wrote:
So I'm not quite sure where you are heading with this patch - is
the
idea that we WANT to allow an external checkpoint with no disks, and
this is fixing a bug that gave an unknown error, or is this a case where
we want to forbid diskless external checkpoints, and you are just
improving the error message?
More concretely, I _want_ to allow a memory-only external snapshot
(particularly of a diskless VM). If this patch is fixing a bogus error
message into allowing that case, then please touch up the commit message
to make that a bit more clear, and I'm fine with including the patch (my
initial read was that this patch is just improving error message quality
but still leaving it an error, but on reflection it looks like I
mis-read the intent because of confusion about the commit message).
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 604 bytes)