Re: [libvirt] [PATCH v3 5/8] Add host cache information in capabilities
On Tue, Apr 25, 2017 at 01:10:29PM +0200, Martin Kletzander wrote:
We're only adding only info about L3 caches, we can add more
later (just by changing one line), but for now that's more than enough
without overwhelming anyone.
XML snippet of how this should look like (also seen as part of the commit):
<cache>
<bank id='0' level='3' type='both' size='8192'
unit='KiB' cpus='0-7'/>
</cache>
Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com>
---
docs/schemas/capability.rng | 34 ++++
src/conf/capabilities.c | 204 ++++++++++++++++++++++++
src/conf/capabilities.h | 29 ++++
src/libvirt_private.syms | 1 +
tests/vircaps2xmldata/vircaps-x86_64-caches.xml | 3 +
tests/vircaps2xmltest.c | 3 +-
6 files changed, 273 insertions(+), 1 deletion(-)
ACK, just need to remember that the followup patch must also use
the same type=both|data|code terminology for its child element.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|