Re: [libvirt] [PATCH 01/11] tlscontext: Make sure to get proper pointer to name

On 01/31/2013 12:28 PM, John Ferlan wrote: Okay, the memset() does the same thing as initializing would have done. Lookin at the preprocessed source, it looks like Coverity is complaining about this snippet of the expansion of PROBE(): __builtin_classify_type (((void * )(intptr_t)(dname))) == 5) ? sizeof (void *) : sizeof (((void *)(intptr_t)(dname)))) and yes, we really DO want to take the sizeof the address, not what it points to, because the point of the PROBE() is to write the address at which data starts. So since it sounds like you were able to shut things up by having a pointer instead of an array to begin with, the simplest solution is thus: char dname[256]; char dnameptr = dname; then PROBE(dnameptr) No need to do PROBE(dnameptr ? dnameptr : "(unknown)"). All we are doing is handing Coverity a pointer instead of an array, although both point to the same data, in order to shut up the false positive. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org