Re: [libvirt PATCH v8 26/37] qemu: improve error handling when restarting nbdkit

On Thu, Aug 31, 2023 at 16:40:06 -0500, Jonathon Jongsma wrote: > Change the return value for qemuNbdkitProcessRestart() and > qemuNbdkitStorageSourceManageProcess() to return an error status. The > main effect of this change is that when libvirt starts up and reconnects > to an already-running domain with an nbdkit-backed disk, it will return > an error if it fails to restart any nbdkit processes that are not found > to be running or if it fails to monitor any running nbdkit processes. > These failures will result in the domain being killed. I don't quite understand why this is a separate patch, but ... > Signed-off-by: Jonathon Jongsma <jjongsma(a)redhat.com&gt; > --- > src/qemu/qemu_driver.c | 3 ++- > src/qemu/qemu_nbdkit.c | 34 ++++++++++++++++------------------ > src/qemu/qemu_nbdkit.h | 4 ++-- > src/qemu/qemu_process.c | 6 ++++-- > 4 files changed, 24 insertions(+), 23 deletions(-) Reviewed-by: Peter Krempa <pkrempa(a)redhat.com&gt;