Re: [libvirt] [PATCH v2 4/5] travis: test "make install" and "make dist" on OS-X

On Wed, Feb 28, 2018 at 04:24:00PM +0100, Andrea Bolognani wrote: > On Wed, 2018-02-28 at 14:55 +0000, Daniel P. Berrangé wrote: > > We can't use "make distcheck" on OS-X because many unit tests fail. We > > s/OS-X/macOS/g > > There are a lot of instances both in the commit message and in the > Travis configuration, please make sure you replace all of them. > > [...] > > @@ -10,6 +10,11 @@ matrix: > > dist: trusty > > - compiler: clang > > os: osx > > + script: > > + # We can't run make distcheck/syntax-check because they > > + # fail on OS-X, but doing 'intsall' and 'dist' gives us > > s/intsall/install/ > > > Reviewed-by: Andrea Bolognani <abologna(a)redhat.com&gt; This isn't quite ready to push after all - it seems our current travis setup for OS-X doesn't have an 'xz' binary installed causing dist to fail. I'll need to figure out which (if any) package we can install to get this binary.