Re: [libvirt] [PATCH] Fix a crash when restarting libvirtd.
On 01/25/2010 02:45 PM, Daniel P. Berrange wrote:
On Mon, Jan 25, 2010 at 02:28:15PM -0500, Chris Lalancette wrote:
> If you shutdown libvirtd while a domain with PCI
> devices is running, then try to restart libvirtd,
> libvirtd will crash.
>
> This happens because qemuUpdateActivePciHostdevs() is calling
> pciDeviceListSteal() with a dev of 0x0 (NULL), and then trying
> to dereference it. This patch fixes it up so that
> qemuUpdateActivePciHostdevs() steals the devices after first
> Get()'ting them, avoiding the crash.
>
> Signed-off-by: Chris Lalancette <clalance(a)redhat.com>
> ---
> src/qemu/qemu_driver.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
...
ACK
Thanks, applied.
--
Chris Lalancette