Re: [libvirt] [PATCH] [RFC] xen domctl version 6

On Wed, Dec 23, 2009 at 10:59:09AM -0700, Jim Fehlig wrote: > xen-unstable c/s 20685 changed the domctl interface, adding a field to > xen_domctl_getdomaininfo structure. This additional field causes stack > corruption in libvirt. xen-unstable c/s 20711 rightly bumped the domctl > interface version so it is at least possible to handle the new field. > > The attached patch accounts for shr_pages field added to > xen_domctl_getdomaininfo structure. I'm not thrilled about the changes > to all the macros - suggestions for improvement welcomed. > > Tested with domctl version 5 and 6. > Yeah, we don't really have much choice there I think, but I would make the macros a bit more forward optimistic, i.e replacing (dom_interface_version == 6 ? with (dom_interface_version >= 6 ? if there is a new bump, the call should not fail because we didn't updated all the macros.