On Thu, Jun 20, 2024 at 04:48:05 +0800, Fima Shevrin wrote:
Hello,
Thank you for your comments and explanations about disk states and snapshots
in general.
I agree that it is quite dangerous to always delete a snapshot in case one
of the variables is NULL.
I modified the patch based on Michal's comment that
qemuSnapshotDeleteValidate should return an error if vmdisk or disk is NULL.
I am attaching the patch and updated commit message.
I apologize for some delay in our discussion.
Sorry for forgetting this patch. Note that I've pushed commit
c1166be3475a0269f5164d87fec6227d6cb34b47 which fixes the same problem
although with better error messages.