Re: [libvirt] [PATCH v2] qemu: Don't fail to shutdown domains with unresponsive agent

On 02/26/2013 04:02 AM, Michal Privoznik wrote:

Currently, qemuDomainShutdownFlags() chooses the agent method of shutdown whenever the agent is configured. However, this assumption is not enough as the guest agent may be unresponsive at the moment. So unless guest agent method has been explicitly requested, we should fall back to the ACPI method. ---

diff to v1: - Rework some conditions as Eric suggested in v1

src/qemu/qemu_driver.c | 38 ++++++++++++++++++++++---------------- 1 file changed, 22 insertions(+), 16 deletions(-)

ACK. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org