Re: [libvirt] [PATCH] Implement virVMOperationType{To|From}String independent from WITH_MACVTAP
2010/12/3 Eric Blake <eblake(a)redhat.com>:
On 12/03/2010 10:43 AM, Matthias Bolte wrote:
> As this symbols are exported independent from WITH_MACVTAP.
> ---
> src/util/macvtap.c | 33 +++++++++++++++++++--------------
> 1 files changed, 19 insertions(+), 14 deletions(-)
ACK.
Thanks, pushed.
Hmm, maybe we should patch ./autobuild.sh to intentionally try a
stripped-down build with as many features disabled as possible to help
catch some of these cases where a full-featured build passes but a
reduced build fails.
Well, that would not have helped to detect this. The problem here is
that we allow undefined symbols to be exported on Linux but use the
libtool -no-undefined option on Windows because exporting undefined
symbols doesn't work on Windows. We should probably just use
-no-undefined on all platforms, or do I miss the reason why we need
this feature of exporting undefined symbols on Linux?
Matthias