On 07/23/2009 02:20 PM, Daniel P. Berrange wrote:
On Thu, Jul 23, 2009 at 01:56:21PM -0400, Cole Robinson wrote:
On 07/23/2009 01:34 PM, Mark McLoughlin wrote:
Hey, Here's a series of patches to implement danpb's suggestion of using 'qemu -M ?' to probe for valid machine types and then to build on that for the machine type canonicalization.
What's the speed difference of GetCapabilities after these patches? Not that it needs to be fast, but it would be useful to know if it's slowwwwwwww.
Urgh, I forgot that that re-builds capabilities on every invocation :-( It might be better to move the refresh into the SIGHUP handler, and have an RPM %trigger against 'qemu' install to send libvirt SIGHUP
Daniel
Maybe internally we could add a CapsRefresh function, which can update the emulator list and scrape output from newly installed emulators, but assume that -M output doesn't change from the first run (or any other output if we ever wanted to scrape device lists, etc.). - Cole