Re: [libvirt PATCH] examples: fix storage volume size schema

On Tue, Oct 06, 2020 at 10:22:27 +0100, Daniel Berrange wrote: > There is no such <storage> element, <capacity> and <allocation> exist at > the top level. > > Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com&gt; > --- > examples/xml/storage/vol-cow.xml | 6 ++---- > examples/xml/storage/vol-qcow.xml | 6 ++---- > examples/xml/storage/vol-qcow2.xml | 6 ++---- > examples/xml/storage/vol-raw.xml | 6 ++---- > examples/xml/storage/vol-sparse.xml | 6 ++---- > examples/xml/storage/vol-vmdk.xml | 6 ++---- > 6 files changed, 12 insertions(+), 24 deletions(-) Definitely an improvement but some of them still don't validate: jing ../../../docs/schemas/storagevol.rng vol* /home/pipo/libvirt/examples/xml/storage/vol-raw.xml:5:10: error: element "volume" incomplete; missing required element "target" /home/pipo/libvirt/examples/xml/storage/vol-sparse.xml:5:10: error: element "volume" incomplete; missing required element "target" I'll probably fix those along with addition to virschematest to prevent this from happening.