Re: [libvirt] [PATCHv2 03/27] build: also check qemu_protocol for on-the-wire stability
On 07/11/2011 02:01 PM, Daniel P. Berrange wrote:
On Fri, Jul 08, 2011 at 01:25:45PM -0600, Eric Blake wrote:
> Since we are going to add some libvirt-qemu.so entry points in
> 0.9.4, we might as well start checking for RPC stability, just
> as for libvirt.so.
>
> * src/Makefile.am (PROTOCOL_STRUCTS): New variable.
> (remote_protocol-structs): Rename...
> (%_protocol-structs): ...and make more generic.
> * src/qemu_protocol-structs: New file.
ACK
Thanks; pushed.
If we want real paranoia we can do src/rpc/virnetprotocol.x too,
though that should basically never be changed by normal patches.
I'll look into that; however, it can't quite reuse the same makefile
rule because libvirt_net_rpc_la-virnetprotocol.lo doesn't fit the
pattern libvirt_driver_remote_la-%_protocol.lo.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 619 bytes)