Re: [libvirt] [PATCH] libvirt-guests: Weaken dependency on libvirtd
On Fri, Oct 07, 2016 at 10:19:53AM +0200, Andrea Bolognani wrote:
The Requires relationship is very strong, in that it prevents
a unit from running unless all the units it Requires are
running as well.
This turns out to be a problem because we want to be able to
restart libvirtd at any time without having libvirt-guests
suspend or shutdown running guests.
Turn the Requires relationship into a Wants relationship:
this way starting libvirt-guests will cause systemd to (attempt
to) start libvirtd as well, but stopping or restarting libvirtd
will not alter libvirt-guests' running state.
I can't figure out how exactly this works, even when looking at the
systemd.unit documentation. You are saying that Wants= means that if
you issue 'service libvirtd stop' it will not save your guests after
this patch. What if you stop the service and then shutdown the machine?
I would agree that it's your fault if it doesn't save your guests. From
what I am reading, it makes sense, so ACK from me. Basically because I
can't come up with scenarios that could be broken by this change =)
Martin
Attachments:
- signature.asc (application/pgp-signature — 801 bytes)