On Tue, 2011-12-20 at 15:35 -0700, Eric Blake wrote:
On 12/12/2011 04:39 PM, Michael Ellerman wrote:
For QEMU PPC64 we have a machine type ("pseries") which has a virtual bus called "spapr-vio". We need to be able to create devices on this bus, and as such need a way to specify the address for those devices.
ACK and pushed. Matches what I had already (pre-emptively) documented, thanks to your doc review of commit fe7fc16.
Thanks.
@@ -2168,6 +2174,34 @@ cleanup: }
static int +virDomainDeviceSpaprVioAddressParseXML(xmlNodePtr node, + virDomainDeviceSpaprVioAddressPtr addr) +{ + char *reg; + int ret; + + memset(addr, 0, sizeof(*addr)); + addr->has_reg = false;
Not strictly necessary - memset already did that.
Yes indeed. I think I added the memset 2nd. cheers